Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] update docker build to add platform targeting #69

Merged
merged 1 commit into from
Mar 15, 2024
Merged

[READY] update docker build to add platform targeting #69

merged 1 commit into from
Mar 15, 2024

Conversation

kylerisse
Copy link
Member

Description of PR

Add platform targeting for docker builds

Previous Behavior

  • Docker build used OS platform/arch by default

New Behavior

  • Docker builds defaults to linux/amd64 by default and is configurable through TARGETPLATFORM var

Tests

  • Built from a darwin/arm system and verified via docker inspect
  • Uploaded to docker hub and verified platform here

@kylerisse kylerisse mentioned this pull request Mar 15, 2024
Merged
sarcasticadmin
sarcasticadmin approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@sarcasticadmin sarcasticadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylerisse great call, would have saved us earlier

@sarcasticadmin sarcasticadmin merged commit dbdd1d8 into socallinuxexpo:master Mar 15, 2024
1 check passed
@kylerisse
Copy link
Member Author

@kylerisse great call, would have saved us earlier

It was all @ruebenramirez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarcasticadmin sarcasticadmin sarcasticadmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylerisse @sarcasticadmin