penalties #112
Merged
penalties #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnwarden
commented
Dec 9, 2022
johnwarden
commented
- improvements to labels and descriptions of penalties chart (Plot estimated penalties #62)
- Increase penaltyWeight from 1.0 to 1.6.
Still just experimenting with what seems to produce good results on the front page
I created this bug while fixing a previous problem with cumulative expected upvotes being incorrect after a large gap in the data (the story doesn't appear in the crawl for a while then comes back)
… we start calculating penalty This is because I notice often pages don't make the home page until reaching a score of 4 (3 upvotes)
I didn't realize that the log() function when run through the Go sqlite library github.com/multiprocessio/go-sqlite3-stdlib was the natural log, not log base 10. When developing and refining the penalties SQL logic I used the sqlite3 commandline tool, where log() was log base 10. Also our code assumes log10 when applying penalties. Make a corresponding increase in our penalty factor by multiplying the factor that felt correct to me, approx 1.5, by ln(10) (because log10(x)*ln(10)*1.5 = ln(x)*1.5)
johnwarden
force-pushed
the
penalties
branch
from
be24f15 to
d7c58c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.