improve error handling #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angusfretwell
force-pushed
the
improve-error-handling
branch
from
54a7f73 to
bd7ba1b
Compare
IanEdington
approved these changes
Sep 25, 2024
| @@ -102,3 +92,47 @@ export async function request( | |||
|
|
|||
| return json.values; | |||
| } | |||
|
|
|||
| function handleError(errorResponse: string | object) { | |||
There was a problem hiding this comment.
You could add a return type of never to this function.
https://www.typescriptlang.org/docs/handbook/2/functions.html#never
Comment on lines
+114
to
+121
| return error; | ||
| } | ||
|
|
||
| try { | ||
| const object = JSON.parse(error); | ||
|
|
||
| if (object && typeof object === "object") { | ||
| return object; |
There was a problem hiding this comment.
In both these return cases, there's an assumption that the objects contain an error_message. One way you could solve this is to move the || "CiviCRM request failed", from line 126 to line 135.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests will now throw a
CiviCRMRequestErrorwith the message provided by the API, if any, and adetailproperty containing any other details provided by the API.