Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Py3.9 and Py3.11
Both are resulting in three test failures:
one example:
Off in the second digit -- is that OK??? I have no idea -- it seems this algorithms do not converge consistently!
NOTE: it might be better to use
math.isclose()
ornumpy.isclose()
for these checks, and set a "good enough" relative tolerance.Changes:
I updated a couple plotting functions so you can pass in an MPL Figure object -- make sit easier to customize . save the plots.
added a couple calls to
profile.close_nc
in the tests.Updated the README with a bit more up to date info about conda, etc.