Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chris updates #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Chris updates #31

wants to merge 3 commits into from

Conversation

ChrisBarker-NOAA
Copy link
Collaborator

Tested with Py3.9 and Py3.11

Both are resulting in three test failures:

FAILED test_blowout.py::test_Blowout_inst - AssertionError: 
FAILED test_blowout.py::test_simulate - AssertionError: 
FAILED test_psm.py::test_psm_Model - AssertionError: 

one example:

test_psm.py:598: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

args = (0.019208730782415875, 0.017327034580027646), kwds = {}

    @wraps(func)
    def inner(*args, **kwds):
        with self._recreate_cm():
>           return func(*args, **kwds)
E           AssertionError: 
E           Items are not equal to 7 significant digits:
E            ACTUAL: 0.019208730782415875
E            DESIRED: 0.017327034580027646

Off in the second digit -- is that OK??? I have no idea -- it seems this algorithms do not converge consistently!

NOTE: it might be better to use math.isclose() or numpy.isclose() for these checks, and set a "good enough" relative tolerance.

Changes:

  • I updated a couple plotting functions so you can pass in an MPL Figure object -- make sit easier to customize . save the plots.

  • added a couple calls to profile.close_nc in the tests.

  • Updated the README with a bit more up to date info about conda, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant