Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Use cmake-generator-expression to set cxx and c flags #4990

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Sep 12, 2024

It allows to differentiate C/C++/CUDA/(maybe other) flags which are passed through dependencies.

Fix compilation problem with

This should be propagated in a potential cleaning of SofaCUDA


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Sep 12, 2024
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 17, 2024
@hugtalbot hugtalbot merged commit e0fc1a9 into sofa-framework:master Sep 25, 2024
11 checks passed
@hugtalbot hugtalbot deleted the cmake_c_cxx_flags branch September 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants