-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mapping.NonLinear] A base class for (almost) all non linear mappings #5006
Merged
fredroy
merged 16 commits into
sofa-framework:master
from
alxbilger:refactoringnonlinearmappings
Oct 1, 2024
Merged
[Mapping.NonLinear] A base class for (almost) all non linear mappings #5006
fredroy
merged 16 commits into
sofa-framework:master
from
alxbilger:refactoringnonlinearmappings
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
pr: breaking
Change possibly inducing a compilation error
pr: status to review
To notify reviewers to review this pull-request
refactoring
Refactor code
labels
Sep 18, 2024
[ci-build][with-all-tests][force-full-build] |
alxbilger
commented
Sep 25, 2024
Sofa/Component/Mapping/NonLinear/src/sofa/component/mapping/nonlinear/BaseNonLinearMapping.h
Outdated
Show resolved
Hide resolved
fredroy
reviewed
Sep 30, 2024
Sofa/Component/Mapping/NonLinear/src/sofa/component/mapping/nonlinear/BaseNonLinearMapping.h
Outdated
Show resolved
Hide resolved
fredroy
approved these changes
Oct 1, 2024
fredroy
force-pushed
the
refactoringnonlinearmappings
branch
from
October 1, 2024 09:58
08fc814
to
37649f9
Compare
bakpaul
approved these changes
Oct 1, 2024
fredroy
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: breaking
Change possibly inducing a compilation error
pr: status ready
Approved a pull-request, ready to be squashed
refactoring
Refactor code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The abstract class
BaseNonLinearMapping
is introduced. All mappings from the folder, exceptRigidMapping
, inherit fromBaseNonLinearMapping
.The class relies on the delegate pattern to simplify the implementation of non-linear mappings. All the affected mappings relied on the same design, so it made sense to factorize common code in a base class.
Breaking because I removed some aliases, made some methods final etc.
What I would like for a next work is to factorize the 3 methods
buildGeometricStiffnessMatrix
,applyDJT
andupdateK
(if possible).By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if