Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mapping.NonLinear] A base class for (almost) all non linear mappings #5006

Merged
merged 16 commits into from
Oct 1, 2024

Conversation

alxbilger
Copy link
Contributor

The abstract class BaseNonLinearMapping is introduced. All mappings from the folder, except RigidMapping, inherit from BaseNonLinearMapping.

The class relies on the delegate pattern to simplify the implementation of non-linear mappings. All the affected mappings relied on the same design, so it made sense to factorize common code in a base class.

Breaking because I removed some aliases, made some methods final etc.

What I would like for a next work is to factorize the 3 methods buildGeometricStiffnessMatrix, applyDJT and updateK (if possible).


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request refactoring Refactor code labels Sep 18, 2024
@bakpaul
Copy link
Contributor

bakpaul commented Sep 24, 2024

[ci-build][with-all-tests][force-full-build]

@fredroy fredroy force-pushed the refactoringnonlinearmappings branch from 08fc814 to 37649f9 Compare October 1, 2024 09:58
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 1, 2024
@fredroy fredroy merged commit 465246f into sofa-framework:master Oct 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: status ready Approved a pull-request, ready to be squashed refactoring Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants