Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Engine] Apply new factory registration mechanism #5010

Merged
merged 4 commits into from
Oct 2, 2024
Merged

[Engine] Apply new factory registration mechanism #5010

merged 4 commits into from
Oct 2, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Sep 23, 2024

See

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 23, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Sep 23, 2024

[ci-build][with-all-tests]

@fredroy fredroy force-pushed the register_engine branch 2 times, most recently from d485a31 to 0e62776 Compare September 23, 2024 04:22
hugtalbot
hugtalbot requested changes Sep 26, 2024
View reviewed changes
Sofa/Component/Engine/Analyze/src/sofa/component/engine/analyze/SumEngine.cpp Outdated Show resolved Hide resolved
...omponent/Engine/Generate/src/sofa/component/engine/generate/ExtrudeEdgesAndGenerateQuads.cpp Outdated Show resolved Hide resolved
...omponent/Engine/Generate/src/sofa/component/engine/generate/ExtrudeQuadsAndGenerateHexas.cpp Outdated Show resolved Hide resolved
Sofa/Component/Engine/Generate/src/sofa/component/engine/generate/ExtrudeSurface.cpp Outdated Show resolved Hide resolved
Sofa/Component/Engine/Generate/src/sofa/component/engine/generate/GenerateCylinder.cpp Outdated Show resolved Hide resolved
Sofa/Component/Engine/Select/src/sofa/component/engine/select/BoxROI.cpp Outdated Show resolved Hide resolved
Sofa/Component/Engine/Select/src/sofa/component/engine/select/IndicesFromValues.cpp Outdated Show resolved Hide resolved
Sofa/Component/Engine/Select/src/sofa/component/engine/select/MeshSplittingEngine.cpp Outdated Show resolved Hide resolved
Sofa/Component/Engine/Select/src/sofa/component/engine/select/SphereROI.cpp Outdated Show resolved Hide resolved
Sofa/Component/Engine/Transform/src/sofa/component/engine/transform/TransformEngine.cpp Outdated Show resolved Hide resolved
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 2, 2024
@hugtalbot hugtalbot merged commit fcd78a7 into sofa-framework:master Oct 2, 2024
10 of 11 checks passed
@hugtalbot hugtalbot deleted the register_engine branch October 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakpaul bakpaul bakpaul approved these changes

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
Refactor object registration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @hugtalbot @bakpaul