-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Topology] Apply new factory registration mechanism #5012
Conversation
00f0b8d
to
040823e
Compare
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #6. To unlock the merge button, you must
|
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #7. To unlock the merge button, you must
|
What happens if you forget the required plugins in the ci-dependent PRs? |
An error message and no object instantiated. |
And why did it work before and not now? |
Because with the "binary" dependencies, the registration was made implicitly when the system are loading the dll, unbeknownst to the pluginmanager . |
.../Topology/Container/Constant/src/sofa/component/topology/container/constant/CubeTopology.cpp
Outdated
Show resolved
Hide resolved
.../Topology/Container/Constant/src/sofa/component/topology/container/constant/MeshTopology.cpp
Outdated
Show resolved
Hide resolved
...ynamic/src/sofa/component/topology/container/dynamic/DynamicSparseGridGeometryAlgorithms.cpp
Outdated
Show resolved
Hide resolved
...Dynamic/src/sofa/component/topology/container/dynamic/DynamicSparseGridTopologyContainer.cpp
Outdated
Show resolved
Hide resolved
.../Dynamic/src/sofa/component/topology/container/dynamic/DynamicSparseGridTopologyModifier.cpp
Outdated
Show resolved
Hide resolved
...ontainer/Dynamic/src/sofa/component/topology/container/dynamic/EdgeSetGeometryAlgorithms.cpp
Outdated
Show resolved
Hide resolved
...Container/Dynamic/src/sofa/component/topology/container/dynamic/EdgeSetTopologyContainer.cpp
Outdated
Show resolved
Hide resolved
.../Container/Dynamic/src/sofa/component/topology/container/dynamic/EdgeSetTopologyModifier.cpp
Outdated
Show resolved
Hide resolved
...er/Dynamic/src/sofa/component/topology/container/dynamic/HexahedronSetGeometryAlgorithms.cpp
Outdated
Show resolved
Hide resolved
...ner/Dynamic/src/sofa/component/topology/container/dynamic/HexahedronSetTopologyContainer.cpp
Outdated
Show resolved
Hide resolved
...iner/Dynamic/src/sofa/component/topology/container/dynamic/HexahedronSetTopologyModifier.cpp
Outdated
Show resolved
Hide resolved
...ainer/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSetTopologyContainer.cpp
Outdated
Show resolved
Hide resolved
...tainer/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSetTopologyModifier.cpp
Outdated
Show resolved
Hide resolved
...onent/Topology/Mapping/src/sofa/component/topology/mapping/CenterPointTopologicalMapping.cpp
Outdated
Show resolved
Hide resolved
...omponent/Topology/Utility/src/sofa/component/topology/utility/TopologicalChangeProcessor.cpp
Outdated
Show resolved
Hide resolved
Sofa/Component/Topology/Utility/src/sofa/component/topology/utility/TopologyBoundingTrasher.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugo <[email protected]>
[ci-depends-on] detected during build #8. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-depends-on] detected during build #9. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-depends-on] detected during build #10. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
See
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/143]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/458]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/305]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if