[all] Various changes relative to the constraint matrix #5017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinearSolverConstraintCorrection::F
is deprecated because it is not used. I believe it stopped to be used here: 50fe60f#diff-b0264445a2a81f648e146f0b1d59d5d197cf3a935f3b7cbb24af11a38b8e6e68L433override
keyword was missing in~LinearSolverConstraintCorrection
LinearSolverConstraintCorrection::J
is renamed tom_constraintMatrix
. Its floating-type is no longerSReal
, butReal
. In theory, it's breaking.computeJ
is no longer used. Instead, I introduce the methodconvertConstraintMatrix
, which is IMO clearer.computeJ
could be removed I think. But for some reasons it is virtual. Anyone overrides it?convertConstraintMatrix
. This must be used for benchmark to evaluate the cost of the conversion. I believe that we can think of a way to avoid the conversions (only if it costs too much).MatrixLinearSolverInternalData::copyJmatrix
is renamed toconvertMatrix
and it is now protected.getLocalJ
clearer.addJMInvJt
CompressedRowSparseMatrixConstraint
,CompressedRowSparseMatrixGeneric
andCompressedRowSparseMatrixMechanical
CompressedRowSparseMatrixConstraint
: added test for the stream operator. The operator no longer adds trailing spaces on each line.CompressedRowSparseMatrixConstraint
CompressedRowSparseMatrixConstraintEigenUtils.h
operator()
inCompressedRowSparseMatrixToEigenSparseVec
. Also added error message if out-of-bounds. Required for Access to the constraint matrix SofaPython3#459is_specialization_of
. Used in a SofaPython3 PRBy submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if