Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SolidMechanics] Apply new factory registration mechanism #5027

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Sep 27, 2024

See


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 27, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Sep 27, 2024

[ci-build][with-all-tests]

Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem on fedora:
@fredroy
fedora_clang_options — Build OK. FIXME: 8 units, 0 scene, 88 regressions

@fredroy
Copy link
Contributor Author

fredroy commented Oct 11, 2024

problem on fedora: @fredroy fedora_clang_options — Build OK. FIXME: 8 units, 0 scene, 88 regressions

done

@epernod epernod self-requested a review October 11, 2024 08:18
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 11, 2024
@epernod epernod merged commit 14820cb into sofa-framework:master Oct 11, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants