Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ODESolver] Rename files to match class name #5034

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[ODESolver] Rename files to match class name #5034

merged 1 commit into from
Oct 2, 2024

Conversation

alxbilger
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request refactoring Refactor code pr: clean Cleaning the code labels Oct 1, 2024
@hugtalbot
Copy link
Contributor

Would you mind adding the C++/CMake compatibility layer? 🙏
I can take over if you need it

@alxbilger
Copy link
Contributor Author

@hugtalbot What is missing?

@bakpaul
Copy link
Contributor

bakpaul commented Oct 1, 2024

I guess nothing is missing ?

@fredroy
Copy link
Contributor

fredroy commented Oct 2, 2024

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 2, 2024
@hugtalbot hugtalbot merged commit f963b06 into sofa-framework:master Oct 2, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakpaul bakpaul bakpaul approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed refactoring Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alxbilger @hugtalbot @bakpaul @fredroy