Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Update example scene of RungeKutta to make it stable #5036

Merged

Conversation

hugtalbot
Copy link
Contributor

Further to #5030 I thought it would be good to have some regression on RK4.

[ci-depends-on https://github.com/sofa-framework/Regression/pull/71]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Oct 1, 2024
@sofabot
Copy link
Collaborator

sofabot commented Oct 1, 2024

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@fredroy
Copy link
Contributor

fredroy commented Oct 1, 2024

[ci-build][with-all-tests]

@sofabot
Copy link
Collaborator

sofabot commented Oct 1, 2024

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@fredroy fredroy force-pushed the 202409_update_RKscheme_example branch from 985428a to 45dac5f Compare October 2, 2024 02:17
@sofabot
Copy link
Collaborator

sofabot commented Oct 2, 2024

[ci-depends-on] detected during build #3.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@fredroy fredroy merged commit 675d752 into sofa-framework:master Oct 2, 2024
8 of 11 checks passed
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants