Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Fix warnings #5054

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

hugtalbot
Copy link
Contributor

Voilà.

Maybe @epernod a check on the SofaPhysicsSimulation with the various Fore/Background member variables.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 10, 2024
@hugtalbot hugtalbot requested a review from epernod October 10, 2024 14:45
Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what is this code for.

@hugtalbot
Copy link
Contributor Author

I let you pass it to ready @epernod 💌

@hugtalbot
Copy link
Contributor Author

Further to @fredroy 's request I added changes in CompressedRowSparseMatrixMechanical
Could you check what I did @alxbilger , do you think this could affect performances?

@hugtalbot
Copy link
Contributor Author

hugtalbot commented Oct 14, 2024

[ci-build][with-all-tests]

@hugtalbot hugtalbot requested a review from alxbilger October 14, 2024 14:58
@alxbilger
Copy link
Contributor

Further to @fredroy 's request I added changes in CompressedRowSparseMatrixMechanical Could you check what I did @alxbilger , do you think this could affect performances?

Casting may introduce a performance cost. However, here the cast is on a constant, which means the compiler is probably able to cast it at compile-time. But the only way to be sure is to read the assembly code...

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 22, 2024
@fredroy fredroy force-pushed the 202410_fix_warnings branch from 7eb0984 to 86b7da4 Compare October 22, 2024 00:24
@fredroy fredroy merged commit d74e879 into sofa-framework:master Oct 22, 2024
11 checks passed
@hugtalbot hugtalbot modified the milestones: v25.06, v24.12 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants