-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Fix warnings #5054
[all] Fix warnings #5054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea what is this code for.
I let you pass it to ready @epernod 💌 |
Further to @fredroy 's request I added changes in CompressedRowSparseMatrixMechanical |
[ci-build][with-all-tests] |
Casting may introduce a performance cost. However, here the cast is on a constant, which means the compiler is probably able to cast it at compile-time. But the only way to be sure is to read the assembly code... |
7eb0984
to
86b7da4
Compare
Voilà.
Maybe @epernod a check on the SofaPhysicsSimulation with the various Fore/Background member variables.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if