[Mass] Apply new factory registration mechanism #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: status wip
|
[ci-build][with-all-tests] |
fredroy
force-pushed
the
register_mass_end
branch
from
892e1a9
to
112f063
Compare
hugtalbot
requested changes
Oct 18, 2024
Sofa/Component/SceneUtility/src/sofa/component/sceneutility/MessageHandlerComponent.cpp
Outdated
Show resolved
Hide resolved
alxbilger
reviewed
Oct 21, 2024
| @@ -101,6 +101,7 @@ class DiagonalMass_test : public BaseTest | |||
| sofa::simpleapi::importPlugin("Sofa.Component.Topology.Container.Dynamic"); | |||
| sofa::simpleapi::importPlugin("Sofa.Component.Topology.Container.Grid"); | |||
| sofa::simpleapi::importPlugin("Sofa.Component.StateContainer"); | |||
| sofa::simpleapi::importPlugin("Sofa.Component.Mass"); | |||
There was a problem hiding this comment.
Unrelated to the PR: I find it confusing that simpleapi::importPlugin does something more than pluginManager.loadPlugin, and it is not obvious which one should be preferred.
Co-authored-by: Hugo <[email protected]>
fredroy
force-pushed
the
register_mass_end
branch
from
99fae5a
to
6f53fbb
Compare
epernod
approved these changes
Oct 26, 2024
epernod
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
(+ add registration from missing components sceneutility and engine.transform)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if