Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Support component included in multiple component change maps #5074

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

alxbilger
Copy link
Contributor

A component can be included in multiple maps (uncreatableComponents, dealiasedComponents, movedComponents). If it is the case, only one was picked and the others were ignored. This PR processes all the maps to inform the user.

Example of output:

The component 'DefaultPipeline' cannot be found in the factory.  
Several reasons are possible:
1) This component has been MOVED from SofaBaseCollision to Sofa.Component.Collision.Detection.Algorithm since SOFA v22.06.
To continue using this component you may need to update your scene by adding
<RequiredPlugin name='Sofa.Component.Collision.Detection.Algorithm'/>  
2) This alias for the component CollisionPipeline was removed in SOFA v24.12.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Oct 21, 2024
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@epernod
Copy link
Contributor

epernod commented Oct 27, 2024

[ci-build][with-all-tests]

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 27, 2024
@fredroy
Copy link
Contributor

fredroy commented Oct 27, 2024

[ci-build][with-all-tests][force-full-build]

@fredroy fredroy merged commit 3d5d5ee into sofa-framework:master Oct 28, 2024
10 of 11 checks passed
@hugtalbot hugtalbot added this to the v24.12 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants