[Type] Consistent string to color conversion #5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
enhancement
bakpaul
reviewed
Nov 14, 2024
| @@ -176,6 +177,30 @@ static std::istream& trimInitialSpaces(std::istream& in) | |||
| return in; | |||
| } | |||
|
|
|||
| const std::map<std::string, RGBAColor> stringToColorMap { | |||
There was a problem hiding this comment.
Couldn't constexpr be used on a map ?
There was a problem hiding this comment.
Ok, it is not possible currently, but serge-sans-paille did it ! https://github.com/serge-sans-paille/frozen
bakpaul
approved these changes
Nov 14, 2024
fredroy
approved these changes
Nov 17, 2024
fredroy
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting from
std::string, the new code is using the already created variables to prevent discrepancies between the string and its values.I also added common additional colors.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if