Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helper] Fix warning unexpected tokens following preprocessor directive #5137

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[Helper] Fix warning unexpected tokens following preprocessor directive #5137

merged 1 commit into from
Nov 22, 2024

Conversation

alxbilger
Copy link
Contributor

With MSVC, I got the following warning:

DynamicLibrary.cpp(114,9): Warning C4067 : unexpected tokens following preprocessor directive - expected a newline

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Nov 22, 2024
@alxbilger alxbilger changed the title [Helper] Fix warning [Helper] Fix warning unexpected tokens following preprocessor directive Nov 22, 2024
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 22, 2024
@hugtalbot hugtalbot merged commit 4cc28d6 into sofa-framework:master Nov 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxbilger @hugtalbot