New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CollisionOBBCapsule] Fix Capsule destructor #5147

Open

alxbilger wants to merge 1 commit into sofa-framework:master from alxbilger:fixcapsuledestructor

+49 −5

Contributor

alxbilger commented Nov 29, 2024

The test introduced in this PR was crashing because of the absence of destructor in CapsuleCollisionModel.

I also added the template Rigid in the factory. It was compiled, but not registered.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

it builds with SUCCESS for all platforms on the CI.
it does not generate new warnings.
it does not generate new unit test failures.
it does not generate new scene test failures.
it does not break API compatibility.
it is more than 1 week old (or has fast-merge label).


          [CollisionOBBCapsule] Fix Capsule destructor

c98a505

alxbilger added pr: fix pr: status to review labels

Contributor

fredroy commented Nov 29, 2024

[ci-build][with-all-tests]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix pr: status to review