[wasm] MP4 example #753
Merged
[wasm] MP4 example #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noituri
force-pushed
the
@noituri/browser-render-mp4
branch
from
a417c71 to
a527f14
Compare
wkozyra95
reviewed
Sep 11, 2024
ts/@live-compositor/browser-render/examples/counter/src/App.tsx
Outdated
Show resolved
Hide resolved
wkozyra95
reviewed
Sep 11, 2024
|
I'm preparing |
noituri
force-pushed
the
@noituri/browser-render-mp4
branch
from
a527f14 to
4dad3e8
Compare
noituri
commented
Sep 11, 2024
| @@ -1,13 +1,16 @@ | |||
| import { defineConfig } from 'vite'; | |||
| import { viteStaticCopy } from 'vite-plugin-static-copy'; | |||
| import { createRequire } from 'node:module'; | |||
|
|
|||
| const require = createRequire(import.meta.url); | |||
There was a problem hiding this comment.
It's a workaround for vite transforming the global require
noituri
commented
Sep 11, 2024
| const buffer = new Uint8ClampedArray(frame.allocationSize(frameOptions)); | ||
| frame.copyTo(buffer, frameOptions); | ||
| const buffer = new Uint8ClampedArray( | ||
| frame.allocationSize(frameOptions as VideoFrameCopyToOptions) |
There was a problem hiding this comment.
as VideoFrameCopyToOptions is needed here because the default typings for VideoFrame are missing format field, even though format is part of the web codecs spec
noituri
commented
Sep 11, 2024
wkozyra95
reviewed
Sep 16, 2024
noituri
force-pushed
the
@noituri/browser-render-mp4
branch
from
8b8dcc6 to
c420eda
Compare
wkozyra95
approved these changes
Sep 17, 2024
|
btw if I open mp4 example, one of the chrome processes memory usage is 10GB. Is this expected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MP4 example for
@live-compositor/browser-render. The example simply plays mp4 video with text component on top of it.Closes #730