[ts-sdk] Add logger #901
Merged
[ts-sdk] Add logger #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
force-pushed
the
@wkozyra95/ts-sdk-add-logger
branch
2 times, most recently
from
5c631d5 to
a8c95c6
Compare
wkozyra95
commented
Dec 18, 2024
| return this.api.registerImage(imageId, intoRegisterImage(request)); | ||
| } | ||
|
|
||
| public async registerWebRenderer( |
There was a problem hiding this comment.
web rendering does not make sense for offline processing because we can't control how fast chrome renders.
I guess it could be used just to render something static, but for now, I think it is better to just disallow it entirely.
wkozyra95
force-pushed
the
@wkozyra95/ts-sdk-add-logger
branch
from
a8c95c6 to
5cd63d0
Compare
Base automatically changed from
@wkozyra95/ts-sdk-mp4-offline-processing
to
master
December 18, 2024 11:25
wkozyra95
force-pushed
the
@wkozyra95/ts-sdk-add-logger
branch
from
5cd63d0 to
8da2701
Compare
BrtqKr
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep adding and removing console logs when debuging, so I added a structured logging library to leave some useful logs in place without spamming users.
I also adjusted the defaults for logging especially for wasm. I want logger configuration to be exposed to user somehow eventually, but for now this is only intended for our use