Add Dockerfile without web renderer #344
Conversation
wkozyra95
force-pushed
the
@wkozyra95/docker-image-variants
branch
from
88bec60 to
9f7460c
Compare
wkozyra95
force-pushed
the
@wkozyra95/docker-image-variants
branch
from
9f7460c to
d089625
Compare
.github/workflows/docker.yml
Outdated
|
|
||
| - uses: hadolint/[email protected] | ||
| with: | ||
| dockerfile: build-tools/docker/full.Dockerfile | ||
|
|
||
| - name: Build image |
There was a problem hiding this comment.
I'm building only slim here, I'm wondering whether it make sense to build both. Any opinions?
There was a problem hiding this comment.
I don't really know. If we're not using too much of the CI time then maybe we should build both versions, but I don't know how to check these limits/the spending
There was a problem hiding this comment.
I don't think there are limits for public repositories. My concern was about witing for CI, but this job is not always run, so maybe it make sense to run both
wkozyra95
force-pushed
the
@wkozyra95/docker-image-variants
branch
from
d089625 to
9fe8523
Compare
build-tools/docker/slim.Dockerfile
Outdated
| ARG USERNAME=compositor | ||
|
|
||
| ENV DEBIAN_FRONTEND=noninteractive | ||
| ENV NVIDIA_DRIVER_CAPABILITIES compute,graphics,utility |
There was a problem hiding this comment.
Shouldn't this be?
| ENV NVIDIA_DRIVER_CAPABILITIES compute,graphics,utility | |
| ENV NVIDIA_DRIVER_CAPABILITIES=compute,graphics,utility |
There was a problem hiding this comment.
this was copy paste from original dockerfile
as far as I remember both syntax are valid, but yes we should be consistent
There was a problem hiding this comment.
Idk if slim is self-explanatory. Maybe so use some name indicating that it removes the web renderer
There was a problem hiding this comment.
Idk if slim is self-explanatory
You are assuming here that slim image means that it's compositor without web renderer :D
It depends what this file is suppose to mean.
- If it is intended to be smaller image with minimal set of feature that do not have any significant downsides (e.g. large size, security issues) then this name is self explanatory and consistent with existing naming conventions
- If it is intended to be full compositor with just web renderer disabled then yes name is not self-explantory
I decided to go with slim because from those 2 approaches it seem to me slightly better, but I don't feel strongly about it.
.github/workflows/docker.yml
Outdated
|
|
||
| - uses: hadolint/[email protected] | ||
| with: | ||
| dockerfile: build-tools/docker/full.Dockerfile | ||
|
|
||
| - name: Build image |
There was a problem hiding this comment.
I don't really know. If we're not using too much of the CI time then maybe we should build both versions, but I don't know how to check these limits/the spending
No description provided.