Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input type that returns data via channel #621

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Add input type that returns data via channel #621

merged 6 commits into from
Jul 11, 2024

Conversation

wkozyra95
Copy link
Member

@wkozyra95 wkozyra95 commented Jul 10, 2024 •
edited
Loading

  • Add input type that can take wgpu::Textures and raw audio
  • Add example of using that input (video only)

@wkozyra95 wkozyra95 force-pushed the @wkozyra95/add-texture-channel-input-type branch from 93e5c71 to d2bd1c8 Compare July 10, 2024 19:22
@wkozyra95 wkozyra95 linked an issue Jul 10, 2024 that may be closed by this pull request
Add support for input streams via Rust channel #613
Closed
@wkozyra95 wkozyra95 changed the title Add input via Rust channel Add output type that returns data via channel Jul 11, 2024
@wkozyra95 wkozyra95 changed the title Add output type that returns data via channel Add input type that returns data via channel Jul 11, 2024
@wkozyra95 wkozyra95 marked this pull request as ready for review July 11, 2024 10:47
wkozyra95
wkozyra95 commented Jul 11, 2024
View reviewed changes
integration_tests/src/test_input.rs
use compositor_render::{scene::RGBColor, Resolution};

#[derive(Debug, Clone)]
pub struct TestInput {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly copied form snapshot test example generation, but rgba instead of yuv

WojciechBarczynski
WojciechBarczynski reviewed Jul 11, 2024
View reviewed changes
compositor_render/src/wgpu/texture/base.rs Outdated Show resolved Hide resolved
compositor_render/src/wgpu/texture/base.rs Outdated Show resolved Hide resolved
compositor_render/src/wgpu/texture.rs Outdated Show resolved Hide resolved
@wkozyra95 wkozyra95 force-pushed the @wkozyra95/add-texture-channel-input-type branch from 1b79053 to b603234 Compare July 11, 2024 13:22
@wkozyra95 wkozyra95 merged commit f326ea5 into master Jul 11, 2024
1 check passed
@wkozyra95 wkozyra95 deleted the @wkozyra95/add-texture-channel-input-type branch July 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechBarczynski WojciechBarczynski WojciechBarczynski approved these changes

@jerzywilczek jerzywilczek Awaiting requested review from jerzywilczek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for input streams via Rust channel
2 participants
@wkozyra95 @WojciechBarczynski