Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Split snapshots into separate files + unify update behavior #850

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

wkozyra95
Copy link
Member

@wkozyra95 wkozyra95 commented Nov 7, 2024

  • Removes a lot of unnecessary error handling and abstractions.
  • Old implementation was allocated everything at the beginning and kept it in memory, which was expensive.
  • Setup was very complicated to modify (flow was more complicated than necessary) e.g. if you want to change the output format
  • Unify update snapshot logic with how integration_tests crates handles it (--feature update_snapshots)

I was also considering:

  • moving tests to integration_tests crate
  • moving scene.json files next to the test *.rs files
    I think it would be better, but I'm not sure if it's worth making such large changes (in terms of files), just to move it.

@wkozyra95 wkozyra95 marked this pull request as ready for review November 7, 2024 09:27
@wkozyra95 wkozyra95 force-pushed the @wkozyra95/snapshot-tests branch from 05ebb36 to e4cd61f Compare November 7, 2024 09:32
@wkozyra95 wkozyra95 merged commit c816a68 into master Nov 8, 2024
4 checks passed
@wkozyra95 wkozyra95 deleted the @wkozyra95/snapshot-tests branch November 8, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant