New architecture for vk-video initialization. #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerzywilczek
requested review from
wkozyra95,
brzep,
WojciechBarczynski and
wkazmierczak
jerzywilczek
force-pushed
the
@jerzywilczek/player-example
branch
7 times, most recently
from
ee1982c to
fee8f15
Compare
wkozyra95
reviewed
Nov 14, 2024
jerzywilczek
force-pushed
the
@jerzywilczek/player-example
branch
3 times, most recently
from
5eebc9d to
e974cf6
Compare
6 tasks
wkozyra95
approved these changes
Nov 19, 2024
jerzywilczek
force-pushed
the
@jerzywilczek/player-example
branch
4 times, most recently
from
5e87a1b to
8cc711a
Compare
This change allows users to initialize `vk-video` with wgpu surfaces for rendering to an on-screen window. This was previously overlooked and there was no possibility to guarantee a `VulkanCtx` was able to render on screen. This patch also adds an example h264 player to vk-video.
jerzywilczek
force-pushed
the
@jerzywilczek/player-example
branch
from
8cc711a to
6731fb5
Compare
WojciechBarczynski
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to initialize
vk-videowith wgpu surfaces for rendering to an on-screen window. This was previously overlooked and there was no possibility to guarantee aVulkanCtxwas able to render on screen.This patch also adds an example h264 player to vk-video.
Closes #821.