[web-wasm] Handle EOS and inputs with different framerates #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noituri
force-pushed
the
@noituri/web-input-state
branch
from
fd1cdbe to
9df0eeb
Compare
wkozyra95
reviewed
Nov 21, 2024
noituri
force-pushed
the
@noituri/web-input-state
branch
3 times, most recently
from
25a4f70 to
a550383
Compare
noituri
force-pushed
the
@noituri/web-input-state
branch
from
a550383 to
7a16f70
Compare
noituri
force-pushed
the
@noituri/web-input-state
branch
from
7a16f70 to
df0152c
Compare
wkozyra95
reviewed
Dec 2, 2024
| type: CompositorEventType.VIDEO_INPUT_PLAYING, | ||
| inputId: this.id, | ||
| }); | ||
| public async getFrameRef(currentQueuePts: number): Promise<FrameRef | undefined> { |
There was a problem hiding this comment.
misleading name, I'm not sure what this function does, but it is definitely a lot more than geting a value
noituri
force-pushed
the
@noituri/web-input-state
branch
from
5262162 to
39c1c80
Compare
noituri
force-pushed
the
@noituri/web-input-state
branch
from
f44fca7 to
fd00e03
Compare
wkozyra95
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling for EOS on inputs and adds support for inputs that have different framerates from the queue framerate.
Closes #810