Allow specifying sample rate per output - add output resamplers #925
Conversation
…default sample rate value for AAC vs 48000 Hz used previously
There was a problem hiding this comment.
I decided to repeat some of this code with one in decoder/resampler, since reusing it would overcomplicate it significantly.
There was a problem hiding this comment.
I'm assuming internal logic for resampling, so I did not check that code. Is this safe assumption?
There was a problem hiding this comment.
Yep, it's copy-paste adjusted to types.
WojciechBarczynski
changed the title
There was a problem hiding this comment.
I'm assuming internal logic for resampling, so I did not check that code. Is this safe assumption?
src/config.rs
Outdated
| const SUPPORTED_SAMPLE_RATES: [u32; 5] = [8_000, 12_000, 16_000, 24_000, 48_000]; | ||
| const DEFAULT_OUTPUT_SAMPLE_RATE: u32 = 48_000; | ||
| let output_sample_rate: u32 = match env::var("LIVE_COMPOSITOR_OUTPUT_SAMPLE_RATE") { | ||
| const SUPPORTED_SAMPLE_RATES: [u32; 6] = [8_000, 12_000, 16_000, 24_000, 44_100, 48_000]; |
There was a problem hiding this comment.
maybe leave the config options as they are,
This something for the future to think about, but maybe we should consider dropping this option and setting 96_000 sample rate or something like this. Do you see any problems with that approach?
There was a problem hiding this comment.
If we use 96000, audio will always be resampled, potentially leading to reduced quality. With the current approach, if users have the same input and output sample rate, they can just set MIXING_SAMPLE_RATE to that value and avoid resampling. I haven't heard any noticeable degradation in quality when resampling to different sample rates, but it probably exists to some extent.
No strong opinion on that.
WojciechBarczynski
force-pushed
the
@WojciechBarczynski/per_output_sample_rate
branch
from
8cb5365 to
43490f3
Compare
WojciechBarczynski
deleted the
@WojciechBarczynski/per_output_sample_rate
branch
I tested it on RTP 24000HZ and MP4 44100 Hz and 48kHz and it seems to be working fine