Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image autoregister #953

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix image autoregister #953

merged 1 commit into from
Feb 7, 2025

Conversation

wkozyra95
Copy link
Member

@wkozyra95 wkozyra95 commented Feb 7, 2025 •
edited
Loading

  • The rust server did not support scheduling image unregister which is necessary for the offline cases (or we could skip unregisters entirely)
  • path field was not passed through the request
  • Types for Mp4 and Image request were incorrect (as a fix I changed values to match, not types)
  • Move newBlocikngTask just before the try-catch (if an exception would throw on asset type it would block rendering indefinitely

Tested on meetup example

wkozyra95
wkozyra95 commented Feb 7, 2025
View reviewed changes
src/routes/unregister_request.rs
@@ -29,11 +29,10 @@ pub struct UnregisterOutput {
}

#[derive(Debug, Serialize, Deserialize, Clone)]
#[serde(tag = "type", rename_all = "snake_case")]
pub enum UnregisterRenderer {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type was not used for anything before

@wkozyra95 wkozyra95 requested a review from BrtqKr February 7, 2025 10:54
@wkozyra95 wkozyra95 merged commit 2bfaa0d into master Feb 7, 2025
5 checks passed
@wkozyra95 wkozyra95 deleted the @wkozyra95/debug-offline-unregister-image branch February 7, 2025 11:19
@wkozyra95 wkozyra95 self-assigned this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrtqKr BrtqKr Awaiting requested review from BrtqKr

Assignees

@wkozyra95 wkozyra95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wkozyra95