-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add structured logging feature #1938
Conversation
@adamw I've tried something, but I'm not sure if I can add a unit test on this feature? |
Sorry not sure how I missed this. Testing logging is difficult, but if you have an idea on how to approach this, go ahead :) |
We should be able to test I'm also going to separate the context construction into a separate class to test it in isolation and allow users to provide their own implementation of the |
@adamw Can you give me a clue as to how to solve the CI failure? I'm having trouble understanding what's wrong. |
It seems that once again the JS builds are broken because of problems with Chrome version / Selenium / some plugin. I'll take a look once I get some time :) |
logging/slf4j/src/main/scala/sttp/client4/logging/slf4j/Slf4jLogger.scala
Outdated
Show resolved
Hide resolved
This looks great, thanks for your work! I fixed the JS build & left two minor comments on the code |
Thanks for the fixes :) |
Close #1932
Before submitting pull request:
sbt compile
sbt compileDocs
sbt test
sbt scalafmt