Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of response specifications #2365

Merged
merged 11 commits into from
Dec 12, 2024
Merged

Improve usability of response specifications #2365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3956457
Move .getRight, .mapLeft etc. to ResponseAs for better discoverability
adamw Dec 10, 2024
9ab3a29
Comment
adamw Dec 10, 2024
7d4ff31
Rename .getRight to .orFail
adamw Dec 10, 2024
f28dcea
Lefover
adamw Dec 10, 2024
1557c5f
Remove specialize response-mapping request functions
adamw Dec 11, 2024
bdb8d00
Docs
adamw Dec 11, 2024
4564784
Revert "Remove specialize response-mapping request functions"
adamw Dec 11, 2024
ae08044
Keep .mapResponseRight in Request only
adamw Dec 11, 2024
62ead1f
Add as...OrFail response-as variants
adamw Dec 11, 2024
e4d8d95
Add asJsonOrFail methods
adamw Dec 11, 2024
29df363
quickRequest now uses asStringOrFail
adamw Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...kend/zio/src/test/scala/sttp/client4/asynchttpclient/zio/AsyncHttpClientZioHttpTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ package sttp.client4.asynchttpclient.zio
import sttp.client4._
import sttp.client4.asynchttpclient.AsyncHttpClientHttpTest
import sttp.client4.impl.zio.ZioTestBase
import sttp.client4.testing.{ConvertToFuture, HttpTest}
import zio.{Task, ZIO}
import sttp.client4.testing.ConvertToFuture
import zio.Task
import zio.ZIO

class AsyncHttpClientZioHttpTest extends AsyncHttpClientHttpTest[Task] with ZioTestBase {

Expand Down
23 changes: 12 additions & 11 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,8 @@ lazy val armeriaZioBackend =
//----- json
lazy val jsonCommon = (projectMatrix in (file("json/common")))
.settings(
name := "json-common"
name := "json-common",
scalaTest
)
.jvmPlatform(
scalaVersions = scala2 ++ scala3,
Expand All @@ -826,7 +827,7 @@ lazy val circe = (projectMatrix in file("json/circe"))
)
.jsPlatform(scalaVersions = scala2 ++ scala3, settings = commonJsSettings)
.nativePlatform(scalaVersions = scala2 ++ scala3, settings = commonNativeSettings)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val jsoniter = (projectMatrix in file("json/jsoniter"))
.settings(
Expand All @@ -842,7 +843,7 @@ lazy val jsoniter = (projectMatrix in file("json/jsoniter"))
settings = commonJvmSettings
)
.jsPlatform(scalaVersions = scala2 ++ scala3, settings = commonJsSettings)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val zioJson = (projectMatrix in file("json/zio-json"))
.settings(
Expand All @@ -858,7 +859,7 @@ lazy val zioJson = (projectMatrix in file("json/zio-json"))
settings = commonJvmSettings
)
.jsPlatform(scalaVersions = scala2 ++ scala3, settings = commonJsSettings)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val zio1Json = (projectMatrix in file("json/zio1-json"))
.settings(
Expand All @@ -874,7 +875,7 @@ lazy val zio1Json = (projectMatrix in file("json/zio1-json"))
settings = commonJvmSettings
)
.jsPlatform(scalaVersions = scala2 ++ scala3, settings = commonJsSettings)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val tethysJson = (projectMatrix in file("json/tethys-json"))
.settings(
Expand All @@ -890,7 +891,7 @@ lazy val tethysJson = (projectMatrix in file("json/tethys-json"))
scalaVersions = scala2 ++ scala3,
settings = commonJvmSettings
)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val upickle = (projectMatrix in file("json/upickle"))
.settings(
Expand All @@ -908,7 +909,7 @@ lazy val upickle = (projectMatrix in file("json/upickle"))
)
.jsPlatform(scalaVersions = scala2 ++ scala3, settings = commonJsSettings)
.nativePlatform(scalaVersions = scala2 ++ scala3, settings = commonNativeSettings)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val json4sVersion = "4.0.7"

Expand All @@ -923,7 +924,7 @@ lazy val json4s = (projectMatrix in file("json/json4s"))
scalaTest
)
.jvmPlatform(scalaVersions = scala2 ++ scala3)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val sprayJson = (projectMatrix in file("json/spray-json"))
.settings(commonJvmSettings)
Expand All @@ -935,7 +936,7 @@ lazy val sprayJson = (projectMatrix in file("json/spray-json"))
scalaTest
)
.jvmPlatform(scalaVersions = scala2 ++ scala3)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val play29Json = (projectMatrix in file("json/play29-json"))
.settings(
Expand All @@ -952,7 +953,7 @@ lazy val play29Json = (projectMatrix in file("json/play29-json"))
settings = commonJvmSettings
)
.jsPlatform(scalaVersions = scala2, settings = commonJsSettings)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val playJson = (projectMatrix in file("json/play-json"))
.settings(
Expand All @@ -967,7 +968,7 @@ lazy val playJson = (projectMatrix in file("json/play-json"))
settings = commonJvmSettings
)
.jsPlatform(scalaVersions = scala2 ++ scala3, settings = commonJsSettings)
.dependsOn(core, jsonCommon)
.dependsOn(core, jsonCommon % compileAndTest)

lazy val prometheusBackend = (projectMatrix in file("observability/prometheus-backend"))
.settings(commonJvmSettings)
Expand Down
Loading
Loading