Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ili2pgValidate] expose dataset parameter #155

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

webrian
Copy link
Contributor

@webrian webrian commented Mar 12, 2024

No description provided.

@webrian webrian linked an issue Mar 12, 2024 that may be closed by this pull request
@webrian webrian requested a review from edigonzales March 12, 2024 21:13
@edigonzales
Copy link
Collaborator

@webrian Könntest du noch einen Test machen? Ist vielleicht bissle tricky zum verstehen. Es braucht a) den Testcode: https://github.com/sogis/gretl/blob/master/gretl/src/integrationTest/java/ch/so/agi/gretl/jobs/Ili2pgValidateTest.java und b) den eigentlichen Job, z.B. https://github.com/sogis/gretl/tree/master/gretl/src/integrationTest/jobs/Ili2pgValidate

@edigonzales
Copy link
Collaborator

@webrian Ah und wenn du es im jetzigen GRETL haben willst, müsste man es noch backporten in den 2.2-Branch.

@webrian
Copy link
Contributor Author

webrian commented Mar 13, 2024

@webrian Ah und wenn du es im jetzigen GRETL haben willst, müsste man es noch backporten in den 2.2-Branch.

Ja, werde ich machen, sobald dieser PR in den Master "squashed and merged" (als ein einzelner Commit) ist. Ist das best practice?

@edigonzales
Copy link
Collaborator

@webrian Ich würde Andi fragen.

@webrian
Copy link
Contributor Author

webrian commented Mar 19, 2024

@edigonzales ist es nun ok, wenn ich merge?

@edigonzales
Copy link
Collaborator

@webrian Ja.

@webrian webrian merged commit 5006175 into master Mar 20, 2024
1 check passed
@webrian webrian deleted the dataset_parameter_ili2pgvalidate branch March 20, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose parameter "dataset" to Ili2pgValidate
2 participants