Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native onchain development - Updated deserialize instruction data lesson #404

Conversation

0xCipherCoder
Copy link
Contributor

Problem

Updated lesson with grammar, syntax, code, and style fixes following guidelines.

Summary of Changes

Fixes #

Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, needs a few tweaks. Note there are others working on this same lesson so competition is fierce!


```rust
user1.age = 37;
```

You can check out the
[struct examples](https://doc.rust-lang.org/rust-by-example/custom_types/structs.html)
for in depth understanding.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links are good. 👍

@0xCipherCoder
Copy link
Contributor Author

0xCipherCoder commented Sep 5, 2024

Good, needs a few tweaks. Note there are others working on this same lesson so competition is fierce!

@mikemaccana Have updated PR and resolved comments. Please check and let me know if there is any additional feedback.

@mikemaccana mikemaccana merged commit 00517d7 into solana-foundation:main Sep 16, 2024
4 checks passed
@mikemaccana
Copy link
Contributor

Thanks @0xCipherCoder ! These look good and I think this is the better contribution of the multiple entries to this lesson's prize. I'm marking you as the winner. Some of the links still need to be updated but we can do that as separately.

@mikemaccana
Copy link
Contributor

As discussed via X we're going to award this to @EmekaManuel since his PR updated the unboxed repos - thanks @0xCipherCoder for being so understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants