Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock web3.js to version 1.x for compatibility #595

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Lock web3.js to version 1.x for compatibility #595

merged 1 commit into from
Nov 6, 2024

Conversation

steveluscher
Copy link
Contributor

nickfrosty
nickfrosty requested changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few of the replacements are removing a package from a few install commands. Can you adjust those ones?

I also left a comment about wallet adapter packages for you

content/courses/token-extensions/close-mint.md
@@ -213,7 +213,7 @@ Next, we'll need to add our dependencies. Run the following to install the
required packages:

```bash
npm i @solana-developers/helpers @solana/spl-token @solana/web3.js esrun dotenv typescript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks like it has a mistake

content/courses/token-extensions/default-account-state.md
@@ -223,7 +223,7 @@ Next, we'll need to add our dependencies. Run the following to install the
required packages:

```bash
npm i @solana-developers/helpers @solana/spl-token @solana/web3.js esrun dotenv typescript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks like it has a mistake

content/courses/token-extensions/immutable-owner.md
@@ -139,7 +139,7 @@ Next, we'll need to add our dependencies. Run the following to install the
required packages:

```bash
npm i @solana-developers/helpers @solana/spl-token @solana/web3.js esrun dotenv typescript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks like it has a mistake

content/courses/token-extensions/interest-bearing-token.md
@@ -213,7 +213,7 @@ Next, we'll need to add our dependencies. Run the following to install the
required packages:

```bash
npm i @solana-developers/helpers @solana/spl-token @solana/web3.js esrun dotenv typescript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks like it has a mistake

content/courses/token-extensions/non-transferable-token.md
@@ -127,7 +127,7 @@ Next, we'll need to add our dependencies. Run the following to install the
required packages:

```bash
npm i @solana-developers/helpers @solana/spl-token @solana/web3.js esrun dotenv typescript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks like it has a mistake

content/courses/token-extensions/permanent-delegate.md
@@ -250,7 +250,7 @@ Next, we'll need to add our dependencies. Run the following to install the
required packages:

```bash
npm i @solana-developers/helpers @solana/spl-token @solana/web3.js esrun
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks like it has a mistake

content/courses/token-extensions/required-memo.md
@@ -177,7 +177,7 @@ Next, we'll need to add our dependencies. Run the following to install the
required packages:

```bash
npm i @solana-developers/helpers @solana/spl-token @solana/web3.js esrun dotenv typescript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks like it has a mistake

content/courses/token-extensions/transfer-fee.md
@@ -459,7 +459,7 @@ Next, we'll need to add our dependencies. Run the following to install the
required packages:

```bash
npm i @solana-developers/helpers @solana/spl-token @solana/web3.js esrun dotenv typescript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks like it has a mistake

content/courses/tokens-and-nfts/nfts-with-metaplex.md Outdated
@@ -345,7 +345,7 @@ Solana.
To begin, make a new folder and install the relevant dependencies:

```bash
npm i @solana/web3.js npm i @solana/web3.js npm i @solana-developers/helpers npm i @metaplex-foundation/mpl-token-metadata npm i @metaplex-foundation/umi-bundle-defaults npm i @metaplex-foundation/umi-uploader-irys npm i --save-dev esrun
npm i @solana/web3.js@1 npm i @solana/web3.js@1 npm i @solana-developers/helpers npm i @metaplex-foundation/mpl-token-metadata npm i @metaplex-foundation/umi-bundle-defaults npm i @metaplex-foundation/umi-uploader-irys npm i --save-dev esrun
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is loaded with duplicate installs. it doesnt look like it was from your pr, buts lets fix it while we are here

Suggested change
npm i @solana/web3.js@1 npm i @solana/web3.js@1 npm i @solana-developers/helpers npm i @metaplex-foundation/mpl-token-metadata npm i @metaplex-foundation/umi-bundle-defaults npm i @metaplex-foundation/umi-uploader-irys npm i --save-dev esrun
npm install @solana/web3.js@1 @solana-developers/helpers@1 @metaplex-foundation/mpl-token-metadata @metaplex-foundation/umi-bundle-defaults @metaplex-foundation/umi-uploader-irys esrun

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I am also intentionally pinning the @solana-developers/helpers package since it uses v1. we are going to release an update version for v2

content/guides/getstarted/full-stack-solana-development.md
@@ -1085,7 +1085,7 @@ Throw this command into your terminal to install all the `wallet-adapter` stuff
we need:

```shell
yarn add react @solana/web3.js \
yarn add react @solana/web3.js@1 \
@solana/wallet-adapter-base @solana/wallet-adapter-react \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to pin any of the wallet adapter packages? either in these install command or in their respective packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope not, but probably.

@steveluscher
Copy link
Contributor Author

Oh, awesome. I knew that a bad regex destroyed one of the 100 PRs I created that day, but I didn't know which one. Turns out, it was this one!

@steveluscher
Copy link
Contributor Author

Updated! It's actually @solana-developers/helpers@2 that you want to lock to, right?

@nickfrosty
Copy link
Collaborator

Ohh you right! v2 on helpers :)

nickfrosty
nickfrosty approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Steven!

@nickfrosty nickfrosty merged commit 8c084d1 into solana-foundation:main Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfrosty nickfrosty nickfrosty approved these changes

@mikemaccana mikemaccana Awaiting requested review from mikemaccana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steveluscher @nickfrosty