Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute the superminority value #33

Merged
merged 8 commits into from
Sep 15, 2024
Merged

Conversation

catalinred
Copy link
Collaborator

@catalinred catalinred commented Sep 9, 2024

This resolves #32.

The Superminority value is now fetched and computed within useTransactionStats, and then displayed accordingly in ValidatorsCards.js.

Preview on /validators:

image

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
solana-com ✅ Ready (Inspect) Visit Preview Sep 13, 2024 4:41pm

@catalinred catalinred requested a review from tigarcia September 9, 2024 15:43
@catalinred
Copy link
Collaborator Author

@tigarcia would you be able to give it a look and confirm this works as expected here?

Copy link

@tigarcia tigarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I added a few comments to clarify some of the changes.

src/hooks/useTransactionStats.js Outdated Show resolved Hide resolved
src/hooks/useTransactionStats.js Show resolved Hide resolved
src/hooks/useTransactionStats.js Show resolved Hide resolved
src/hooks/useTransactionStats.js Show resolved Hide resolved
Copy link

@tigarcia tigarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@catalinred catalinred merged commit 7f61b2d into main Sep 15, 2024
3 checks passed
@catalinred catalinred deleted the feat/compute-superminority branch September 15, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Superminority value is static
2 participants