SIMD-0167: Loader-v4 #167
Open
SIMD-0167: Loader-v4 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfrosty
reviewed
Aug 22, 2024
proposals/0167-loader-v4.md
Outdated
| otherwise throw `UnsupportedProgramId` | ||
| - the program account is at least as long enough for the header, | ||
| otherwise throw `AccountDataTooSmall` | ||
| - the status stored in the program account is not retracted, |
There was a problem hiding this comment.
why would status of deployed or finalized throw an error?
should this be when the status is retracted?
There was a problem hiding this comment.
The check asserts that the status is not retracted, thus only retracted throws the error.
Lichtso
force-pushed
the
loader-v4
branch
12 times, most recently
from
fc20b4e to
bd5ab89
Compare
topointon-jump
approved these changes
Nov 1, 2024
|
|
||
| - loader-v3 clears the program proxy account (setting its size to zero) | ||
| - loader-v3 transfers all funds from the programdata to the proxy account | ||
| - loader-v3 gifts the program proxy account to loader-v4 |
There was a problem hiding this comment.
How would the gifting work? Do we need to add a new instruction to the v3 loader? Will this upgrade mechanism be specified in a future SIMD?
There was a problem hiding this comment.
I see three options here:
- A migrate instruction for loader-v3 which the dApp devs trigger themselves
- A migrate instruction for loader-v3 which we the protocol engineers trigger
- A feature gate which scans the accounts DB and migrates all loader-v3 programs
I would prefer the second option as that allows us to keep the gathering of the loader-v3 program list and then slowly working through it off-chain and still makes sure that all loader-v3 programs get migrated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.