SIMD-0094: deprecate executable update for bpf loader #94
Conversation
HaoranYi
force-pushed
the
deprecate_executable_update
branch
from
682af53 to
d421ef8
Compare
HaoranYi
changed the title
HaoranYi
force-pushed
the
deprecate_executable_update
branch
2 times, most recently
from
0ba43fb to
44d8b94
Compare
HaoranYi
force-pushed
the
deprecate_executable_update
branch
2 times, most recently
from
db6882f to
771e728
Compare
HaoranYi
force-pushed
the
deprecate_executable_update
branch
from
771e728 to
a5ba969
Compare
HaoranYi
force-pushed
the
deprecate_executable_update
branch
from
a5ba969 to
19f7eea
Compare
HaoranYi
force-pushed
the
deprecate_executable_update
branch
from
19f7eea to
82adfa8
Compare
|
Removing myself as a reviewer since I'm not well-versed in the loader details. I defer to @Lichtso and other reviewers. |
Yeah. I pushed a commit to update this SIMD according to the changes in SIMD-0162. |
HaoranYi
force-pushed
the
deprecate_executable_update
branch
3 times, most recently
from
1dc1974 to
2cde862
Compare
HaoranYi
changed the title
HaoranYi
force-pushed
the
deprecate_executable_update
branch
from
2cde862 to
8b85018
Compare
HaoranYi
force-pushed
the
deprecate_executable_update
branch
from
8b85018 to
5151ea8
Compare
| - any dapps that depend on `is_executable` to be true on the serialized | ||
| instruction accounts. Existing program deployed on chain will work fine. | ||
| However, if the program is redeployed, it may be broken. Before redeployment, | ||
| dapps developer will need to check and update the program if it depends on | ||
| `is_executable`. |
There was a problem hiding this comment.
Possibly a big deal for dApp developers, cc @acheroncrypto
There was a problem hiding this comment.
Yes, it is a bit disruptive. But it is a good step to move forward.
Once this change is done, we can skip serialize "executable" flag at all, which is a good win to serialization time too.
There was a problem hiding this comment.
Possibly a big deal for dApp developers, cc @acheroncrypto
It shouldn't affect Anchor as long as AccountInfo.executable doesn't change (see solana-labs/solana#34425 (comment)).
There was a problem hiding this comment.
The usage of is_executable and executable is a bit confusing. I think using something like <TYPE>.is_executable would help resolve this ambiguity.
There was a problem hiding this comment.
It shouldn't affect Anchor as long as
AccountInfo.executabledoesn't change (see solana-labs/solana#34425 (comment)).
Yeah. updated.
There was a problem hiding this comment.
It shouldn't affect Anchor as long as
AccountInfo.executabledoesn't change (see solana-labs/solana#34425 (comment)).
@acheroncrypto With this proposal, AccountInfo.executable will change. In the original implementation that you mentioned above, AccountInfo.executable doesn't change because we emulate it at serialization time. But that turns out to be very expensive - 10X increase of serialization. Therefore, in this proposal, we won't emulate executable at serialization time. Hence, dapp can't depend on AccountInfo.executable directly. Is that going to be an issue?
Add deprecate executable metadata update for bpf loader SIMD