Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate PublicKey from isAddressLookupTableAccount #304

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Eliminate PublicKey from isAddressLookupTableAccount #304

merged 1 commit into from
Oct 18, 2023

Conversation

steveluscher
Copy link
Collaborator

@steveluscher steveluscher commented Oct 18, 2023 •
edited
Loading

We don't need an entire PublicKey instance just to assert on the address of the owner.

Test Plan

  1. Visit https://explorer-git-10-18-overrideavsctov577onnpm-solana-labs.vercel.app/address/DnXcJm7zT3cWYXTUaf9Mww2Q12EEwuuU5LtvQzV8ZvzQ/entries?cluster=devnet

Observe table entries are there.

@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 3:52am

@steveluscher
Copy link
Collaborator Author

steveluscher commented Oct 18, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@steveluscher steveluscher mentioned this pull request Oct 18, 2023
Merged
@steveluscher steveluscher force-pushed the 10-17-Eliminate_PublicKey_from_isAddressLookupTableAccount_ branch from 54d715d to cc73f37 Compare October 18, 2023 00:01
@steveluscher steveluscher marked this pull request as ready for review October 18, 2023 00:01
@steveluscher steveluscher force-pushed the 10-17-Update_to_experimental_web3.js_2.0.0-experimental.7adc22b branch from 7df0c64 to 5856efc Compare October 18, 2023 00:14
@steveluscher steveluscher force-pushed the 10-17-Eliminate_PublicKey_from_isAddressLookupTableAccount_ branch from cc73f37 to 0504ce2 Compare October 18, 2023 00:14
@steveluscher steveluscher mentioned this pull request Oct 18, 2023
Merged
@steveluscher steveluscher force-pushed the 10-17-Update_to_experimental_web3.js_2.0.0-experimental.7adc22b branch from 5856efc to 959073a Compare October 18, 2023 00:21
@steveluscher steveluscher force-pushed the 10-17-Eliminate_PublicKey_from_isAddressLookupTableAccount_ branch from 0504ce2 to c7c3e96 Compare October 18, 2023 00:21
@steveluscher
Copy link
Collaborator Author

steveluscher commented Oct 18, 2023 •
edited
Loading

Merge activity

@steveluscher steveluscher force-pushed the 10-17-Update_to_experimental_web3.js_2.0.0-experimental.7adc22b branch from 959073a to 6d006ad Compare October 18, 2023 03:49
Base automatically changed from 10-17-Update_to_experimental_web3.js_2.0.0-experimental.7adc22b to master October 18, 2023 03:50
@steveluscher steveluscher force-pushed the 10-17-Eliminate_PublicKey_from_isAddressLookupTableAccount_ branch from c7c3e96 to acc2d75 Compare October 18, 2023 03:50
@steveluscher steveluscher merged commit 68e07e5 into master Oct 18, 2023
3 checks passed
@steveluscher steveluscher deleted the 10-17-Eliminate_PublicKey_from_isAddressLookupTableAccount_ branch October 18, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@steveluscher