Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The inspector will now accept a transaction, a versioned transaction, a message, or a versioned message #340

Merged
merged 1 commit into from
May 17, 2024

Conversation

steveluscher
Copy link
Collaborator

Test plan

Visit /tx/inspector and paste in the following.

A legacy transaction

AgEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAgEDBr+lhud1kh3/T9hG50HSqUZkigC5oGEhBnZyS4LPpMtOoYNBYtiONrVgr6gFD9j0si5UpgcznwgouB+gSvl3B6SV8XEiQm+zr1FpjDDa95qgzbREkjpJrSxl/GrpAnuA0gAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABqHYF5E3VCqYNDe9/ip6slV/U1yKeHIraKSdwAAAAAAGp9UXGSxcUSGMyUw9SvF/WNruCJuh/UTj29mKAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAgMDAAIBYwMAAAChg0Fi2I42tWCvqAUP2PSyLlSmBzOfCCi4H6BK+XcHpAcAAAAAAAAAc3Rha2U6MADKmjsAAAAAyAAAAAAAAAAGodgXkTdUKpg0N73+KnqyVX9TXIp4citopJ3AAAAAAAQCAgV0AAAAAL+lhud1kh3/T9hG50HSqUZkigC5oGEhBnZyS4LPpMtOv6WG53WSHf9P2EbnQdKpRmSKALmgYSEGdnJLgs+ky04AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=

A version 0 transaction

AgEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBgAIBAwa/pYbndZId/0/YRudB0qlGZIoAuaBhIQZ2ckuCz6TLTqGDQWLYjja1YK+oBQ/Y9LIuVKYHM58IKLgfoEr5dweklfFxIkJvs69RaYww2veaoM20RJI6Sa0sZfxq6QJ7gNIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAah2BeRN1QqmDQ3vf4qerJVf1NcinhyK2ikncAAAAAABqfVFxksXFEhjMlMPUrxf1ja7gibof1E49vZigAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAIDAwACAWMDAAAAoYNBYtiONrVgr6gFD9j0si5UpgcznwgouB+gSvl3B6QHAAAAAAAAAHN0YWtlOjAAypo7AAAAAMgAAAAAAAAABqHYF5E3VCqYNDe9/ip6slV/U1yKeHIraKSdwAAAAAAEAgIFdAAAAAC/pYbndZId/0/YRudB0qlGZIoAuaBhIQZ2ckuCz6TLTr+lhud1kh3/T9hG50HSqUZkigC5oGEhBnZyS4LPpMtOAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

A legacy message

AgEDBr+lhud1kh3/T9hG50HSqUZkigC5oGEhBnZyS4LPpMtOoYNBYtiONrVgr6gFD9j0si5UpgcznwgouB+gSvl3B6SV8XEiQm+zr1FpjDDa95qgzbREkjpJrSxl/GrpAnuA0gAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABqHYF5E3VCqYNDe9/ip6slV/U1yKeHIraKSdwAAAAAAGp9UXGSxcUSGMyUw9SvF/WNruCJuh/UTj29mKAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAgMDAAIBYwMAAAChg0Fi2I42tWCvqAUP2PSyLlSmBzOfCCi4H6BK+XcHpAcAAAAAAAAAc3Rha2U6MADKmjsAAAAAyAAAAAAAAAAGodgXkTdUKpg0N73+KnqyVX9TXIp4citopJ3AAAAAAAQCAgV0AAAAAL+lhud1kh3/T9hG50HSqUZkigC5oGEhBnZyS4LPpMtOv6WG53WSHf9P2EbnQdKpRmSKALmgYSEGdnJLgs+ky04AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=

A versioned message

gAIBAwa/pYbndZId/0/YRudB0qlGZIoAuaBhIQZ2ckuCz6TLTqGDQWLYjja1YK+oBQ/Y9LIuVKYHM58IKLgfoEr5dweklfFxIkJvs69RaYww2veaoM20RJI6Sa0sZfxq6QJ7gNIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAah2BeRN1QqmDQ3vf4qerJVf1NcinhyK2ikncAAAAAABqfVFxksXFEhjMlMPUrxf1ja7gibof1E49vZigAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAIDAwACAWMDAAAAoYNBYtiONrVgr6gFD9j0si5UpgcznwgouB+gSvl3B6QHAAAAAAAAAHN0YWtlOjAAypo7AAAAAMgAAAAAAAAABqHYF5E3VCqYNDe9/ip6slV/U1yKeHIraKSdwAAAAAAEAgIFdAAAAAC/pYbndZId/0/YRudB0qlGZIoAuaBhIQZ2ckuCz6TLTr+lhud1kh3/T9hG50HSqUZkigC5oGEhBnZyS4LPpMtOAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 9:09pm

@steveluscher
Copy link
Collaborator Author

I got tired of Explorer not working with the output of --dump-transaction-message.

@steveluscher steveluscher force-pushed the fix-transaction-inspector branch from 30dedfd to 9cbfa91 Compare May 17, 2024 21:07
@ngundotra
Copy link
Collaborator

ngundotra commented May 17, 2024

Can you update the inspector's text here with the supported byte data?

Screenshot 2024-05-17 at 5 09 08 PM

@steveluscher
Copy link
Collaborator Author

Can you update the inspector's text here with the supported byte data?

I'm so afraid to, because that would mean committing to keeping that working forever, when really I have half a mind that we should just eliminate support for decoding wire transactions altogether.

@steveluscher
Copy link
Collaborator Author

To be clear, pasting a valid base64 legacy message into Explorer today will break it. Try the ‘legacy message’ with Explorer in prod right now.

@steveluscher
Copy link
Collaborator Author

ie. This is not a ‘feature’ PR, it's a bug fix.

@ngundotra
Copy link
Collaborator

What do you think about adding the following somewhere in the UI?

support for tx.serialize() will end soon, please transition to tx.message.serialize()
or
supported formats Message, VersionedMessage, and (deprecated) Transaction, (deprecated) VersionedTransaction

@steveluscher
Copy link
Collaborator Author

What do you think about adding the following somewhere in the UI?

I think that would be a fine thing for someone else to do, who's actually going to see that through (ie. not me).

@steveluscher steveluscher merged commit e2e1106 into master May 17, 2024
4 checks passed
@steveluscher steveluscher deleted the fix-transaction-inspector branch May 17, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants