Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source code url and fix --commit-hash bug #406

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

Woody4618
Copy link
Contributor

@Woody4618 Woody4618 commented Nov 11, 2024

Showing the repository URL in that case the on chain PDA was uploaded.

Fix:
The -- commit hash was always shown even when there was no commit hash used in the verify args

Copy link

vercel bot commented Nov 11, 2024

@Woody4618 is attempting to deploy a commit to the Solana Labs Team on Vercel.

A member of the Team first needs to authorize it.

@Woody4618
Copy link
Contributor Author

Woody4618 commented Nov 11, 2024

These are the different states:

Verified:
image

Not verified pda uploaded:
image

Not verified:
image

@Woody4618 Woody4618 changed the title Add Self verify state and fix commit hash bug Add source code url and fix --commit-hash bug Nov 12, 2024
@ngundotra ngundotra merged commit b9af433 into solana-labs:master Nov 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants