fix(serve:ui): remove sudo, pass remaining cmdline args to serve (#44)

* fix(serve:ui): remove sudo, pass remaining cmdline args to serve

* fix: add cleanup for ERR

bin/blockexplorer.sh

@@ -36,20 +36,15 @@ cleanup() {
     [[ -z $pid ]] || kill "$pid"
   done
 }
-trap cleanup SIGINT SIGTERM
+trap cleanup SIGINT SIGTERM ERR
 
 set -x
 redis-cli ping
 
 node build/api/api.js &
 api=$!
 
-maybeSudo=
-if [[ $(uname) = Linux ]]; then
-  # Run as root for port 80 access
-  maybeSudo=sudo
-fi
-$maybeSudo npm run serve:ui &
+npm run serve:ui &
 ui=$!
 
 wait "$ui"

package.json

@@ -65,7 +65,7 @@
     "re": "semantic-release --repository-url [email protected]:solana-labs/blockexplorer.git",
     "start:api": "set -ex; redis-cli ping; babel-node --presets env api/api.js",
     "start:ui": "react-scripts start",
-    "serve:ui": "serve -l 80 -s build",
+    "serve:ui": "serve -s build",
     "test:ui": "react-scripts test"
   },
   "files": [