[spl-token-2022-js]: Add SetTransferFee instruction

[iMrDJAi]

While it's possible to create a Mint with a transfer fee in TypeScript with createInitializeTransferFeeConfigInstruction(), there seem to be no way to update the fee later.

[buffalojoec]

Ah, thanks for calling this out, looks like we just need to add the functions to support SetTransferFee in a similar fashion to the others!

[sam41306061]

Hello @buffalojoec , Is this issue still open at the moment?

[buffalojoec]

Hello @buffalojoec , Is this issue still open at the moment?

Yes, appears so! Would you like to work on it?

[sam41306061]

@buffalojoec Yeah, I would like to take a crack at it. For context, do you have a repo or project where you are using this where I can see exactly what you outlined above?

[buffalojoec]

@buffalojoec Yeah, I would like to take a crack at it. For context, do you have a repo or project where you are using this where I can see exactly what you outlined above?

solana-program-library/token/js/src/extensions/transferFee/instructions.ts

Lines 63 to 89 in 5ce6eac

	export function createInitializeTransferFeeConfigInstruction(
	mint: PublicKey,
	transferFeeConfigAuthority: PublicKey | null,
	withdrawWithheldAuthority: PublicKey | null,
	transferFeeBasisPoints: number,
	maximumFee: bigint,
	programId = TOKEN_2022_PROGRAM_ID
	): TransactionInstruction {
	if (!programSupportsExtensions(programId)) {
	throw new TokenUnsupportedInstructionError();
	}
	const keys = [{ pubkey: mint, isSigner: false, isWritable: true }];
	const data = Buffer.alloc(initializeTransferFeeConfigInstructionData.span);
	initializeTransferFeeConfigInstructionData.encode(
	{
	instruction: TokenInstruction.TransferFeeExtension,
	transferFeeInstruction: TransferFeeInstruction.InitializeTransferFeeConfig,
	transferFeeConfigAuthorityOption: transferFeeConfigAuthority ? 1 : 0,
	transferFeeConfigAuthority: transferFeeConfigAuthority || new PublicKey(0),
	withdrawWithheldAuthorityOption: withdrawWithheldAuthority ? 1 : 0,
	withdrawWithheldAuthority: withdrawWithheldAuthority || new PublicKey(0),
	transferFeeBasisPoints: transferFeeBasisPoints,
	maximumFee: maximumFee,
	},
	data
	);

We're missing a function like this for SetTransferFee.

[buffalojoec]

Rust side:

solana-program-library/token/program-2022/src/extension/transfer_fee/instruction.rs

Lines 397 to 422 in 5ce6eac

	pub fn set_transfer_fee(
	token_program_id: &Pubkey,
	mint: &Pubkey,
	authority: &Pubkey,
	signers: &[&Pubkey],
	transfer_fee_basis_points: u16,
	maximum_fee: u64,
	) -> Result<Instruction, ProgramError> {
	check_program_account(token_program_id)?;
	let mut accounts = Vec::with_capacity(2 + signers.len());
	accounts.push(AccountMeta::new(*mint, false));
	accounts.push(AccountMeta::new_readonly(*authority, signers.is_empty()));
	for signer in signers.iter() {
	accounts.push(AccountMeta::new_readonly(**signer, true));
	}
	Ok(Instruction {
	program_id: *token_program_id,
	accounts,
	data: TokenInstruction::TransferFeeExtension(TransferFeeInstruction::SetTransferFee {
	transfer_fee_basis_points,
	maximum_fee,
	})
	.pack(),
	})
	}

[nasjuice]

Hello,

I added a PR for this here
#6678