Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spl-token-2022-js]: Add SetTransferFee instruction #6678

Merged
merged 2 commits into from
May 4, 2024
Merged

[spl-token-2022-js]: Add SetTransferFee instruction #6678

merged 2 commits into from
May 4, 2024

Conversation

nasjuice
Copy link
Contributor

@nasjuice nasjuice commented May 3, 2024

Problem
As pointed out at #5451

Solution
Add SetTransferFee endpoint

Fixes #5451

@mergify mergify bot added the community Community contribution label May 3, 2024
@nasjuice nasjuice mentioned this pull request May 3, 2024
Closed
buffalojoec
buffalojoec reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I left a few small comments, and looks like you have to run lint!

token/js/src/extensions/transferFee/instructions.ts Outdated Show resolved Hide resolved
token/js/src/extensions/transferFee/instructions.ts Outdated Show resolved Hide resolved
token/js/src/extensions/transferFee/instructions.ts Outdated Show resolved Hide resolved
token/js/src/extensions/transferFee/actions.ts Outdated Show resolved Hide resolved
token/js/test/e2e-2022/transferFee.test.ts Outdated Show resolved Hide resolved
@nasjuice
Copy link
Contributor Author

nasjuice commented May 3, 2024

Thank you for the review, I have fixed the comments

buffalojoec
buffalojoec approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding this!

@buffalojoec buffalojoec merged commit f0b0ced into solana-labs:master May 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buffalojoec buffalojoec buffalojoec approved these changes

Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spl-token-2022-js]: Add SetTransferFee instruction
2 participants
@nasjuice @buffalojoec