[token-2022] Create proof-program feature #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind if I merge #4039 before this? Then we can get a clean release out before all of the zk changes |
|
Yes, definitely! Let's release a clean version first. |
This was referenced Mar 12, 2023
HaoranYi
pushed a commit
to HaoranYi/solana-program-library
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a PR in progress solana-labs/solana#29996 that updates the proof verification program so that it break token-2022 confidential transfer. This results in downstream CI tests to fail.
Summary of Changes
Temporarily create a
proof-programfeature in the token-2022 program to disable the components that uses the proof program. Once solana-labs/solana#29996 is merged and solana-program is updated, either make theproof-programfeature as default or remove the feature altogether.