[token-cli] Enable configuring confidential transfer account #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-transfers` commands
…ntial account configure commands
joncinque
reviewed
Oct 17, 2023
token/cli/src/main.rs
Outdated
Comment on lines
4657
to
4665
| .arg( | ||
| Arg::with_name("account") | ||
| .validator(is_valid_pubkey) | ||
| .value_name("TOKEN_ACCOUNT_ADDRESS") | ||
| .takes_value(true) | ||
| .index(1) | ||
| .required(true) | ||
| .help("The address of the token account to configure confidential transfers for") | ||
| ) |
There was a problem hiding this comment.
For all of these, similar to create-account, how about taking in a "mint" and using the owner's ATA for that mint if "account" isn't specified?
There was a problem hiding this comment.
Yeah, that is a good idea. It turned out it is slightly clunky since account and token can all be optional. Please take a look. I think this suggestion also applies for all other commands that take in account as a required argument.
joncinque
reviewed
Oct 18, 2023
Co-authored-by: Jon Cinque <[email protected]>
joncinque
previously approved these changes
Oct 18, 2023
Co-authored-by: Jon Cinque <[email protected]>
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
|
Oh man sorry for all the mess and hassle this PR and thanks for your patience. |
joncinque
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The token-cli does not yet support initializing confidential transfer account
Summary of changes
Added configuring cli commands for confidential transfer accounts. I think each commits should be pretty straightforward and independent with the following note:
configure-confidential-transfer-account, I made it so that the elgamal and aes keys are derived from the signer by default. This can be updated so that users have the option to initialize the account with custom keys once we upgrade to clap-v3-utils.