Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single-pool-js: Fix ci #5594

Merged
merged 1 commit into from
Oct 18, 2023
Merged

single-pool-js: Fix ci #5594

merged 1 commit into from
Oct 18, 2023

Conversation

joncinque
Copy link
Contributor

Problem

The single-pool js tests are failing in CI, e..g https://github.com/solana-labs/solana-program-library/actions/runs/6560481835/job/17818975411

Solution

It was fiddly, but I needed to make two changes -- one to use the import flag instead of loader, and then to use the common js loader instead of esm. Who knows why this works? Not me! 🙃

@joncinque joncinque marked this pull request as ready for review October 18, 2023 13:06
@joncinque joncinque requested a review from 2501babe October 18, 2023 13:06
@2501babe
Copy link
Member

uhh that's really weird... im just gonna check what happens without the commonjs change in a separate pr because i have no idea why it would want that, considering files are... not cjs

@2501babe
Copy link
Member

ok nevermind I reproduced locally. god this is infuriating. the loader flag is necessary to make everything use ts, but the import flag doesnt actually do what the loader flag is supposed to do, and they removed the loader flag. i hate this platform so much and i also dont care either, if it works it works

@2501babe 2501babe merged commit 5ce6eac into solana-labs:master Oct 18, 2023
9 checks passed
@joncinque joncinque deleted the spjsci branch October 18, 2023 20:49
@joncinque
Copy link
Contributor Author

Ah nice job tracking that down! Looks like I got frustrated and quit sooner than you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants