Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance: remove Rent from the CreateGovernance doc #5723

Closed
wants to merge 1 commit into from
Closed

Governance: remove Rent from the CreateGovernance doc #5723

wants to merge 1 commit into from

Conversation

0xShuk
Copy link
Contributor

@0xShuk 0xShuk commented Nov 3, 2023

No description provided.

@mergify mergify bot added the community Community contribution label Nov 3, 2023
@github-actions github-actions bot added the stale [bot only] Added to stale content; will be closed soon label Nov 29, 2023
@buffalojoec
Copy link
Contributor

@0xShuk Is this still relevant? And should it be applied to other instructions?

@0xShuk
Copy link
Contributor Author

0xShuk commented Nov 29, 2023

@0xShuk Is this still relevant? And should it be applied to other instructions?

Yes. The CreateGovernance instruction no longer needs the rent account, the doc is misleading. Other instructions are fine.

@github-actions github-actions bot removed the stale [bot only] Added to stale content; will be closed soon label Nov 30, 2023
@buffalojoec
Copy link
Contributor

buffalojoec commented Nov 30, 2023 •
edited
Loading

It looks like there's more than one to update. The PR where most of this was changed is #2838.

I'd really appreciate it if you included those in this PR!

cc @SebastianBor

@SebastianBor
Copy link
Contributor

It looks like there's more than one to update. The PR where most of this was changed is #2838.

Correct, the Rent account is not used and it applies to all CreateXxxxGovernance instructions

@0xShuk 0xShuk mentioned this pull request Dec 5, 2023
Merged
@0xShuk
Copy link
Contributor Author

0xShuk commented Dec 5, 2023

@buffalojoec @SebastianBor I have created a new PR which includes all four ixs: #5949

@0xShuk 0xShuk closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianBor SebastianBor Awaiting requested review from SebastianBor

Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xShuk @buffalojoec @SebastianBor