Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt.toml for SPL #5729

Closed
wants to merge 2 commits into from
Closed

rustfmt.toml for SPL #5729

wants to merge 2 commits into from

Conversation

buffalojoec
Copy link
Contributor

This PR adds a rustfmt.toml to the SPL repository.

I've included only the file itself with configs for review. Once we agree on the configs for the whole workspace, I can run the formatter and PR the changes.

@buffalojoec buffalojoec requested a review from joncinque November 6, 2023 11:40
@buffalojoec
Copy link
Contributor Author

Note this will also include the mandatory use of nightly, thus CI modifications will be required as part of this change.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we embrace these different features one by one? It seems like this will be chaos if we just enable all of them in one commit.

Let's start with group_imports and imports_granularity, and then we can see how each option impacts the repo before adding it.

Maybe we can even start with using nightly format in CI before adding this file. What do you think?

token/rustfmt.toml Outdated Show resolved Hide resolved
@buffalojoec
Copy link
Contributor Author

Let's start with group_imports and imports_granularity, and then we can see how each option impacts the repo before adding it.

Maybe we can even start with using nightly format in CI before adding this file. What do you think?

yeah this is going to result in a bazillion changes so I'm in favor of splitting it up.

@buffalojoec
Copy link
Contributor Author

Closing in favor of #5741

@buffalojoec buffalojoec closed this Nov 7, 2023
@buffalojoec buffalojoec deleted the spl-rustfmt branch February 23, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants