rustfmt: format comments #5744
Merged
rustfmt: format comments #5744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
buffalojoec
force-pushed
the
11-07-rustfmt_format_imports
branch
from
9974918 to
7ab732b
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_format_comments
branch
from
369f733 to
c302e9c
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_format_imports
branch
from
7ab732b to
866e3bf
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_format_comments
branch
from
c302e9c to
ff38393
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_format_imports
branch
from
866e3bf to
f1571f5
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_format_comments
branch
from
ff38393 to
c01a2d1
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_format_imports
branch
from
f1571f5 to
88907a4
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_format_comments
branch
from
c01a2d1 to
3210d34
Compare
joncinque
reviewed
Nov 7, 2023
There was a problem hiding this comment.
There's definitely some rough edges, but I think we'll eventually be able to land this! There were a lot of places that created weirdness, and sometimes my review comments are a bit terse, so please don't take them negatively. Once we cleanup those bits, this should be good to go. Please do it in new commits so that I don't have to go through the whole thing again 🙏
token/program-2022/src/extension/confidential_transfer/instruction.rs
Outdated
Show resolved
Hide resolved
token/program-2022/src/extension/confidential_transfer/instruction.rs
Outdated
Show resolved
Hide resolved
😅 😅 😅 I will probably not do this right away hah. Thanks for a thorough review though! |
Please do it on the sooner side to avoid merge conflicts later! I really don't want to go through all of this again. |
Ah nuts. |
buffalojoec
force-pushed
the
11-07-rustfmt_format_imports
branch
from
88907a4 to
0413540
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_format_comments
branch
from
3210d34 to
39aca11
Compare
|
Holy schmoly, |
buffalojoec
force-pushed
the
11-07-rustfmt_format_comments
branch
from
39aca11 to
e49bd7c
Compare
joncinque
previously approved these changes
Nov 8, 2023
Comment on lines
+14
to
+15
| // Start Governance custom errors from 500 to avoid conflicts with programs | ||
| // invoked via CPI |
| /// 6. `[signer]` Payer | ||
| /// 7. `[]` bpf_upgradeable_loader program | ||
| /// 8. `[]` System program | ||
| /// 9. `[]` Sysvar Rent | ||
| /// 10. `[signer]` Governance authority | ||
| /// 11. `[]` RealmConfig account. PDA seeds: ['realm-config', realm] | ||
| /// 11. `[]` RealmConfig account. | ||
| /// * PDA seeds: ['realm-config', realm] |
Merge activity
|
buffalojoec
force-pushed
the
11-07-rustfmt_format_imports
branch
from
0413540 to
4005ab6
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_format_comments
branch
from
e49bd7c to
b0f135a
Compare
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comment formatting configurations to the repository's
rustfmt.tomlfile, and the associated changes fromcargo +nightly fmt --all.Comment width 80.