js: Move everything to pnpm #5775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
force-pushed
the
pnpm
branch
2 times, most recently
from
b19249a to
7563d76
Compare
buffalojoec
reviewed
Nov 9, 2023
token-swap/js/.eslintrc
Outdated
There was a problem hiding this comment.
We could enforce eslint and prettier at the root level for all libs (like rustfmt). pnpm will pick it up.
Also, have you seen @solana/eslint-config-solana?
There was a problem hiding this comment.
Ah cool, I added that as an item in #5785, and I can definitely use the @solana version!
buffalojoec
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's a lot of libraries in SPL, and managing all of their dependencies can take awhile, especially as all of the dependabot PRs come in.
Solution
Move everything to one pnpm-lock.yaml file! As I was going through the different packages, there were loads of issues, so I had to fix up a few other things. This is step 1, and after this, we can change all of the deps in the package.json files to use the version from
workspace:*Note: this is currently set to draft while CI gets happy