-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[account compression] Clean up tests #5847
Conversation
@jnwng @buffalojoec @joncinque Before adding some features to SPL account compression (in follow up PRs), do you guys have any preference on how the SPL Account Compression test suite is written? |
From what I can tell all of the JS libraries do tests their own way, but we are migrating all of them to use Specifically how the tests are written: I don't have any objections myself! |
@joncinque might not be the place to discuss but this did remind me of Solana Bankrun, which we can use to test our JS libs. |
Okay, I actually split up the tests into a few different spots, should run a bit faster on local now since they can be parallelized by jest. Also way easier to read now. Should be evident from the |
Jest is normally the recommended test suite over mocha. And definitely use bankrun rather than spinning up a test validator to test against, if you can! |
It is not eminently clear that zero-length instructions work, so add a test case for this in e2e tests.
Addresses concern in #5092