account-compression: Move sdk to pnpm workspace #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngundotra
reviewed
Nov 28, 2023
| @@ -8,6 +8,7 @@ on: | |||
| - "ci/*-version.sh" | |||
| - "ci/install-anchor.sh" | |||
| - ".github/workflows/pull-request-account-compression.yml" | |||
| - "!account-compression/sdk/**" | |||
There was a problem hiding this comment.
what does this do & why add?
There was a problem hiding this comment.
The ! means to not run if there's a change in one of those files.
The idea is to not run this workflow if there's only a change to the JS side, since pull-request-js.yml gets run if there's only a change on the JS side. But if there's a change in the program, you do want to run this workflow.
There was a problem hiding this comment.
But if there's a change in the SDK the tests should run. SDK can change test behavior
There was a problem hiding this comment.
Yep, the SDK tests are run by pull-request-js.yml if there's a change there
ngundotra
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During the update to 1.17.6 in #5863, it looks like the build barfs on account-compression not being part of the pnpm workspace
Solution
Move the account-compression sdk to the same workspace! This way it'll also pick up dependabot changes like the rest of the repo.
This also required some dependency bumps because the current build has some unmet dependencies according to pnpm.
Note that the linting isn't working, so I can fix that in a follow-up PR.